[Freeciv-Dev] Re: (PR#2102) default user name "name"

["Andreas Kemnade" <akemnade@xxxxxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=2102 >

On Tue, 23 Mar 2004 09:16:58 -0800
"Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx> wrote:

> 
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=2102 >
> 
> Andreas Kemnade wrote:
> 
> > Please look at the archive why we don't check for win32 functions.
> > So the WIN32_NATIVE macro has to be used.
> 
> The archive is unsearchable at the moment.  Can you be any more specific?
> 
The point is you cannot check for functions of the win32 api easily on mingw32.
__stdcall is the name of the problem. You do not have a symbol called 
GetUserName somewhere but you might have GetUserName@8 if GetUserName would a 
function (It is a macro).
The 8 is the number of bytes for the parameters on the stack.
The Win32 API is present on every win32 compiler so there is no need to check
that, especially because checking is not that easy.
That's basically what was our conclusion when the mingw32 support was
added in common and server code. At that time we had the discussion, too. 
CLib functions are possible compiler dependant and therefore you should check 
them.
Functions in other libs as well. These functions do not have that
__stdcall attribute. So there are no problems to check for them. 

A few other problems (not mentioned at that time):
configure is quite restrictive against different
gcc versions. gcc-2.95 ist not fully supported anymore (the gtk client needs
3.X, the win32 client works with both).
People using M$ VC have to create a config.h by hand. When checks for
win32 api functions are added, they would have to insert dozens of entries for 
all the win32 functions by hand into their config.h. 

Greetings
Andreas Kemnade