[Freeciv-Dev] Re: (PR#2102) default user name "name"

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=2102 >

Per I. Mathisen wrote:
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=2102 >
> 
> On Mon, 22 Mar 2004, Jason Short wrote:
> 
>>- Don't use the WIN32_NATIVE macro. Instead add windows.h to
>>AC_CHECK_HEADERS and GetUserName to AC_CHECCK_FUNCS in configure.ac and
>>configure.in, and use these macros instead.
> 
> Why is this better? It is not like other OSes use this function.

That's not the point.  This is the preferred autoconf way, and for a reason.

The main problem is that WIN32_NATIVE doesn't have a good 
(configure-time) check for it.  All that configure can check for is if 
the host matches with *mingw*.  Anyone using a different compiler will 
have to fix things manually.  By comparison checks for specific 
functions and headers will always succeed.

In other places there is code like

   #if defined WIN32_NATIVE || defined __BEOS__ || defined __EMX__

which should also be replaced by a proper configure check.

jason