[Freeciv-Dev] Re: (PR#2102) default user name "name"

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=2102 >

James Canete wrote:
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=2102 >
> 
> I'm not sure, so here's a version with code to make it sane.

The concept is good.  However:

- Don't use the WIN32_NATIVE macro.  Instead add windows.h to 
AC_CHECK_HEADERS and GetUserName to AC_CHECCK_FUNCS in configure.ac and 
configure.in, and use these macros instead.

- Don't duplicate the code from is_sane_name.  This code will have to be 
changed soon to fix the charset problems.  Instead we should have a 
common function.  Probably you should just call is_sane_name, and if 
that fails then use the fallback naming methods.  This should be a 
fairly rare problem.  is_sane_char() is a possibility, but remember than 
some charsets may have multiple-byte characters.

- Read over the style guide (doc/CodingStyle).  Your spacing is "wrong" 
in some places.

jason