[Freeciv-Dev] Re: (PR#8109) Only a dead veteran is a good veteran

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8109 >

Per I. Mathisen wrote:
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=8109 >
> 
> On Tue, 16 Mar 2004, Christian Knoke wrote:
> 
>>Game: Your attacking Cruise Missile succeeded against Mária Terézia's Mech. 
>>Inf.
>>outside of Szatmárnémeti and became more experienced!
> 
> Haha. Good one!
> 
> Should we add the no veteran flag to such units, or make the missile flag
> disable the above message? (In the latter case, the missile can still
> become veteran by defending itself from attack.)

Both are too complicated IMO.  The make-veteran check should just be 
moved down so it's run after the missile-death check, and should check 
if the unit is still alive (if necessary).

jason