[Freeciv-Dev] Re: (PR#7895) voting doesn't work with commands with arguments

["Per I. Mathisen" <per@xxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=7895 >

On Sat, 13 Mar 2004, James Canete wrote:
> Seems "A little work here and there" consisted of changing caller to
> NULL. :)

Actually, the proper fix is a little bit more complicated:

--- server/stdinhand.c  16 Mar 2004 14:42:40 -0000      1.309
+++ server/stdinhand.c  16 Mar 2004 14:45:42 -0000
@@ -3319,7 +3319,7 @@
              _("Ambiguous option name."));
     return FALSE;
   }
-  if (!may_set_option(caller,cmd)) {
+  if (!may_set_option(caller,cmd) && !check) {
      cmd_reply(CMD_SET, caller, C_FAIL,
               _("You are not allowed to set this option."));
     return FALSE;

;-)

The problem was only with the /set command, AFAICT.

  - Per