[Freeciv-Dev] Re: (PR#7375) Unify some mapview code

["Raimar Falke" <i-freeciv-lists@xxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=7375 >

On Thu, Feb 05, 2004 at 11:08:10PM -0800, Jason Short wrote:
> 
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=7375 >
> 
> > [i-freeciv-lists@xxxxxxxxxxxxx - Wed Feb 04 15:11:17 2004]:
> > 
> > 
> > With the new canvas_store_{create,free} function it is possible to
> > remove some more code.
> 
> I like it a lot.
> 
> [Looking at version 3.]
> 
> Even if the tile width is not changed, we should still update the width
> and height.  These values are stored accurately in the mapview struct
> and may someday be used for more accurate judgements (like in animation).

If we really need this we should add two sets of values. One for the
canvas and one for the window. While canvas size >= window size.

struct canvas {
  int map_x0, map_y0;
  int canvas_width, canvas_height;              /* Size in pixels. */
  int window_width, window_height;              /* Size in pixels. */
  int tile_width, tile_height;  /* Size in tiles. Rounded up. */
  struct canvas_store *store;
};

> I'd also really like to see support for Win32 and SDL clients before
> we apply it...

It only moves code around. I don't see a problem here.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "Life is too short for reboots."