[Freeciv-Dev] Re: (PR#7232) message each time changing production

["Raimar Falke" <i-freeciv-lists@xxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=7232 >

On Thu, Feb 05, 2004 at 08:12:17PM -0800, Jason Short wrote:
> This change certainly fixed a bug.  But there were two bugs working
> together to get the right result (two wrongs do make a right!), so now
> things don't work.  Because E_NOEVENT is passed in to the function
> (E_NOEVENT == -1), the "else" clause is now invoked which causes
> E_UNIT_BUILD to (incorrectly) be the event sent to the client (rather
> than E_NOEVENT).  Thus we get the buggy behavior of change-build events
> being treated like build-completed events.
> 
> The attached patch should fix this; it adds a new event.

You can't add an event inside the enum. While the network protocol is
safe here with the mandatory capability the client option file isn't
(the data is saved by the event number).

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "Sit, disk, sit. Good boy. Now spin up. Very good. Here's a netscape
  cookie for you. Fetch me some data. Come on, you can do it. No, not that
  data. Bad disk. Bad." 
    -- Calle Dybedahl, alt.sysadmin.recovery