Complete.Org: Mailing Lists: Archives: freeciv-dev: February 2004:
[Freeciv-Dev] (PR#6897) leak in ai_diplomacy_suggest
Home

[Freeciv-Dev] (PR#6897) leak in ai_diplomacy_suggest

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: undisclosed-recipients: ;
Subject: [Freeciv-Dev] (PR#6897) leak in ai_diplomacy_suggest
From: "Benoit Hudson" <bh@xxxxxxxxxxxxxxxxxxx>
Date: Wed, 4 Feb 2004 16:04:51 -0800
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=6897 >

> [bhudson - Thu Nov 20 04:59:12 2003]:
> 
> > [i-freeciv-lists@xxxxxxxxxxxxx - Wed Nov 19 11:46:37 2003]:
> > What about the client? I have the feeling something similar had to be
> > done to the close_diplomacy_dialog functions?
> 
> Possibly, but that function (at least in the gtk2 client) doesn't seem
> to be the place where we free the dialog: diplomacy_destroy is.  I don't
> have the patience to fix every client in this respect, but here's a
> lightly tested patch for gtk2 (I met with someone, added a clause, then
> cancelled, and it correctly called treaty_clear) and a totally untested
> patch for gtk.

I've been playing with this patch active since then.  No problems I can
attribute to it.


[Prev in Thread] Current Thread [Next in Thread]
  • [Freeciv-Dev] (PR#6897) leak in ai_diplomacy_suggest, Benoit Hudson <=