[Freeciv-Dev] Re: (PR#7344) Expanded Orders

["Raimar Falke" <i-freeciv-lists@xxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=7344 >

On Sun, Feb 01, 2004 at 01:03:02AM -0800, Arnstein Lindgard wrote:
> 
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=7344 >
> 
> On Sat, 31 Jan 2004 19:05:16 -0800 Raimar Falke wrote:
> > 
> > What is ORDER_NONE?
> 
> It's convenient and more explicit for a default in savegame, and
> in a couple of places in client as with:
> 
>   hover_mission = ORDER_NONE
>     just like
>   hover_state = HOVER_NONE
> 
> instead of ORDER_LAST.

I don't understand the hover_state comment. However I know from
TECH_NONE that I really don't like another *_NONE. So can you explain
in more detail the "default in savegame". It sounds like a placeholder
for a slot. But why do you need the slot in the first place?

> > > +/* For client to determine which sprite to display. */
> > > +enum movement_type {
> > > +  GOTO_ORDERS, PATROL_ORDERS, STATIONARY_ORDERS
> > > +};
> > 
> > The values should get a prefix.
> 
> I'll put ORDERS first then?

Singular. Also if we get the "send orders back to the client" patch
the scope of this enum is tilespec.c?!

> > > +    /* Information for client to display sprites correctly. */
> > > +    enum unit_orders mission;       /* The last order in the list. */
> > > +    enum movement_type move_type;   /* Goto, Patrol, Stationary.   */
> > 
> > I really don't like this. We should really send the order list back to
> > the client. We agreed on this before and the above is only a kludge
> > around this.
> 
> Jason, do we agree to send the list back? Should be quick to change.

Jason?

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  "Windows is the one true OS. MS invented the GUI. MS invented 
   the 32 bit OS. MS is open and standard. MS loves you. We have 
   always been at war with Oceana."