[Freeciv-Dev] Re: (PR#7369) [RFC] Coding style

["Jason Short" <jshort@xxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=7369 >

>
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=7369 >
>
>
> We currently have both
>
> int foo()
> {
>   return p->bar;
> }
>
> and
>
> int foo()
> {
>   return (p->bar);
> }
>
> Can we change to coding style so that one is preferred?

Between these, I prefer

  return p->bar;

However, in more complicated statements I prefer

  return (some_random_lengthy_value_number_one()
          && some_random_lengthy_value_number_two());

over

  return some_random_lengthy_value_number_one()
    && some_lengthy_random_value_number_two();

Note that the first is formatted "properly" according to the style guide
(and most editors will give you this).  AFAIK the style guide does not
specify a formatting for the second (and editors may be inconsistent).

So my preference would be: no-parenthesis for single-line, parenthesis for
multi-line.

jason