[Freeciv-Dev] Re: (PR#6931) Returning GR_FAILED in execute_orders doesn't cancel unit orders

["Gregory Berkolaiko" <Gregory.Berkolaiko@xxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=6931 >

On Mon, 26 Jan 2004, Raimar Falke wrote:

> 
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=6931 >
> 
> On Sun, Jan 25, 2004 at 11:22:32PM -0800, Jason Short wrote:
> > 
> > <URL: http://rt.freeciv.org/Ticket/Display.html?id=6931 >
> > 
> > Here's a new version of the cancel-failed-orders-properly patch.
> > 
> > No changes; just updated for CVS.
> 
> I agree with you on the wrapper vs no-wrapper problem.
> 
> What are the remaining uses of the enum? Can't it just be killed?
> 
> Gregory: you added the enum some time ago. You said this information
> was required and that the callers will make use of this. Please comment.

I guess I was wrong.  The callers that would use it never materialised.  
And now I cannot remember if I wanted to convert anything to use it.

AI only uses dead/not dead value.
There is one place where you might want to use sucess/not value:
http://www.freeciv.org/lxr/source/server/unittools.c#L445

So we can reduce the number of return values to 3:
OK, FAIL, DIED

G.