[Freeciv-Dev] (PR#6931) Returning GR_FAILED in execute_orders doesn't cancel unit orders

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=6931 >

> [i-freeciv-lists@xxxxxxxxxxxxx - Sun Jan 25 07:59:16 2004]:

> > Execute_orders should just return a bool indicating whether the unit
> > survives.  Any other handling should be done within the function. 
> > Perhaps a wrapper function would be helpful (to handle the different
> > return values).  If not then the GR_*** enumeration can just be dropped.
> 
> I'm for the wrapper. Else the functions grow too much.

A wrapper or sub-function saves 6 lines of code - fewer lines than it
would take to write the extra function.

A wrapper is bad in any case since we would have a 3-fold return value
that needed a new enum:

  OR_DEAD
  OR_DONE
  OR_CANCELLED

which is unnecessary.  The goto_result shouldn't be re-used since it is
intended for a different purpose.

jason