[Freeciv-Dev] Re: (PR#7304) iso-map support for mapgen

["Gregory Berkolaiko" <Gregory.Berkolaiko@xxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=7304 >

Sorry for not answering on IRC

On Sun, 25 Jan 2004, Jason Short wrote:

> <URL: http://rt.freeciv.org/Ticket/Display.html?id=7304 >
> 
> > [Gregory.Berkolaiko@xxxxxxxxxxxxx - Sun Jan 25 19:48:22 2004]:
> > 
> > 2. We should agree on a policy where the name of a coordinate would 
> > indicate its type.  I am really aginst things like
> >     native_to_map_pos(&x, &y, x, y);
> > It seems the default is map coords, so native should _always_ be called 
> > (xn, yn).
> 
> I've now renamed some variables, but not all.  I didn't rename most
> variables that I didn't create.

I think all of them should be renamed.  Even if it's too much of line 
change, I tink it's worth it.  The least that we can do is to add comments 
in the functions that are fully native-coordinated wihtout changing the 
actual coordinate names.

G.