[Freeciv-Dev] Re: (PR#7301) Unified and cached overview

["Jason Short" <jshort@xxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=7301 >

On Sat, 24 Jan 2004, Raimar Falke wrote:

>
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=7301 >
>
>
> The patch does two things:
>
> First it moves a lot of overview related code to mapview common. This
> is possible since we have with struct canvas_store efficiently a nice
> abstraction of a canvas. This is enough to remove almost all overview
> drawing code from the various guis.

Yes.

Rather than have a function to return the overview canvas store you should
put this variable into mapview_common.h.  See mapview_canvas and
map_overview_x0 that are already there.

> The second part is to cache the overview so that if only the position
> of the main map view is changed the overview doesn't have to be
> redrawn completely like it is done in the current code.

Huh?  This is already the case.  I don't see what you've changed here.

jason