Complete.Org: Mailing Lists: Archives: freeciv-dev: August 2003:
[Freeciv-Dev] Re: (PR#5057) Diplomats can't go on ennemy tiles 		Home

[Freeciv-Dev] Re: (PR#5057) Diplomats can't go on ennemy tiles

[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: remi.bonnet@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#5057) Diplomats can't go on ennemy tiles
From: "Gregory Berkolaiko" <Gregory.Berkolaiko@xxxxxxxxxxxx>
Date: Wed, 13 Aug 2003 06:35:42 -0700
Reply-to: rt@xxxxxxxxxxxxxx 
On Wed, 13 Aug 2003, Jason Short wrote:

> Gregory Berkolaiko wrote:
> 
> > The second part I am not sure about.  I propose a slightly different fix 
> > attached as dip_act_gb.diff.  The original patch is attached as 
> > dip_act_rb.diff
> 
> The original patch's correctness is obvious to me.  Yours isn't, but I 
> haven't read the entire function.

The first condition is much stricter than the second.  And for ACTION_ANY 
they should be ORred.  So we only need to check the second.

G.
[Prev in Thread] Current Thread [Next in Thread]