[Freeciv-Dev] Re: (PR#3771) Uproar display of cities

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

Jason Short wrote:
> Gregory Berkolaiko wrote:
> 
>>Jason,
>>
>>Have you found where 
>>"the full city packet is erronously (I think) being sent out."
>>?
>>
>>If not, this patch will further mask the place where this bug occurs.  I 
>>think we have to find this wrong packet first.
> 
> 
> Hmm, I don't think it will mask the bug, but we do have to find it...

It looks to me like all calls are safe, so the city_info is only sent to 
the owner and observers.  But since the unhappy info is never sent by 
the short_city packet I don't understand how another player's client 
knows about it at all.

> IMO we need a clean separation of the internal view of a city versus the 
> external view.  Players with an internal view get a city_info packet 
> while those with an external view get a short_city packet.
> 
> My question is, who has an internal view?
> 
> - The player.
> - An investigating spy (temporary; special case).
> - Anyone at union with the player?
> - Anyone with shared vision with the player?
> 
> Currently it is only the first two.

Plus observers.

jason