Complete.Org: Mailing Lists: Archives: freeciv-dev: July 2003:
[Freeciv-Dev] Re: (PR#4633) Assertion triggers in citydlg_common.c:320
Home

[Freeciv-Dev] Re: (PR#4633) Assertion triggers in citydlg_common.c:320

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: undisclosed-recipients: ;
Subject: [Freeciv-Dev] Re: (PR#4633) Assertion triggers in citydlg_common.c:320
From: "mateusz stefek" <matusik_s@xxxxx>
Date: Tue, 22 Jul 2003 04:44:39 -0700
Reply-to: rt@xxxxxxxxxxxxxx

on 2003.07.21 18:23, Jason Short wrote:
> 
> [jdorje - Mon Jul 21 15:38:58 2003]:
> 
> > The logical conclusion is that short_city packets should only be
> sent
> > for cities we can't see and city_info packets only for cities that
> we
> > can.  "see" means see the internals of, not see on the map...

Oh, I see. It's in packhand.c:596 and 624

> The attached patch fixes one place where short_city packets may be
> sent
> to players who can see the city.
> 
The patch seems to fix my problem.

Maybe we should also check the owner of a city in handle_short_city() 
and exit with warning if something is wrong.

--
mateusz



[Prev in Thread] Current Thread [Next in Thread]