[Freeciv-Dev] Re: (PR#2581) Layers Patch

["Gregory Berkolaiko" <Gregory.Berkolaiko@xxxxxxxxxxxx>]

On Sat, 10 May 2003, Raahul Kumar wrote:

> > > Air units must defend against other air unit attackers if they are 
> > > present.
> > > Ground unit vs ground attacker, sea vs sea etc. The best defender is not
> > > necessarily picked.
> > 
> > For that you need to change get_defender too, which is not done, AFAICS
> 
> One of us is hallucinating, Greg. I could have sworn 
> 
> diff -ruN -Xdiff_ignore Cvs_Freeciv/common/combat.c Freeciv/common/combat.c
> --- Cvs_Freeciv/common/combat.c       Fri Dec  6 20:47:47 2002
> +++ Freeciv/common/combat.c   Fri Dec  6 21:38:48 2002
> @@ -489,7 +489,9 @@
>       } else if (build_cost == best_cost) {
>         if (rating_of_best < defense_rating) {        
>           change = TRUE;
> -       }
> +       } else if (is_same_layer(attacker, defender)) {
> +            change = TRUE; /* Units of the the attackers layer type */
> +          }
>       }
>        }
> 
> was there. Which version of my layer patch are you looking at? Do not apply my
> old patch! I will update to current CVS and send in a new one. Tell me if you
> don't like my implementation. If you can do a detailed review, I'll be happy.
> Note: Doesn't have to be Greg doing the review. Any of the usual suspects will
> do. 

Ugh, sorry if I didn't notice it.  But it won't work in this way, I think.