[Freeciv-Dev] Re: (PR#4196) Enemies in allied transport assert.

["Gregory Berkolaiko" <Gregory.Berkolaiko@xxxxxxxxxxxx>]

On Thu, 8 May 2003, Gregory Berkolaiko wrote:

> If there are enemies in a transport of your ally and you attempt to move 
> onto the tile, you get an assert from get_defender.
> 
> Even if we decide that ally of an ally cannot be enemy, this is still a 
> bug, as the lacks robustness and the error message comes from a wrong 
> place.

Upon further reflection, I concluded that they units in the transport of 
your ally don't have to be your enemies.  Can be peaceful (but not allied) 
units as well.  Which means that this bug is idependent of LLH 
(love-love-hate triangle) bug.

So the original patch is probably the best.

I we just return NULL when an attack cannot be carried out due to 
alliances, this will confuse AI in the future, when it starts considering 
attacking people it's currentlyat peace with.

However, for the originalpatch to work seamlessly, we need to change 
handle_unit_move_request accordingly.

G.