[Freeciv-Dev] Re: (PR#3973) [PATCH] Revised patch which creates new "novice" skill level

["Gregory Berkolaiko" <Gregory.Berkolaiko@xxxxxxxxxxxx>]

Quoting Reinier Post <rp@xxxxxxxxxx>:

> On Thu, Apr 17, 2003 at 01:03:18PM -0700, Gregory Berkolaiko wrote:
> > 
> > Hi,
> > 
> > You patch applied well against CVS, I updated the thing which I didn't 
> > like (the floats) and also fixed a bug which appeared when I tried to load
> 
> > games with a novice.  The problem seems to be that update_research was 
> > called before the science_rate was properly set.
> > 
> > Please check the patch.  I think it is ready for inclusion.
> 
> I don't like the idea of having a "novice" level (or any other level)
> that magically sets some hidden variables.  The original patch had the
> right interface, in my opinion.  Better fix this in the other direction
> by making the "skill"-influenced variables real variables whose
> names start with "ai.".

skill is an attribute of a single AI player, not the whole server

the patch implements a handicap given to an AI player.  And all handicaps should
eventually be implemented in the server, like this one.

I feel this is the right implementation.

G.