Complete.Org: Mailing Lists: Archives: freeciv-dev: April 2003:
[Freeciv-Dev] Re: (PR#3973) Re: (PR#3977) [PATCH] Revised patch which cr
Home

[Freeciv-Dev] Re: (PR#3973) Re: (PR#3977) [PATCH] Revised patch which cr

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: sam+civ@xxxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#3973) Re: (PR#3977) [PATCH] Revised patch which creates new "novice" skill level
From: "Reinier Post" <rp@xxxxxxxxxx>
Date: Fri, 18 Apr 2003 02:38:15 -0700
Reply-to: rt@xxxxxxxxxxxxxx

On Thu, Apr 17, 2003 at 01:03:18PM -0700, Gregory Berkolaiko wrote:
> 
> Hi,
> 
> You patch applied well against CVS, I updated the thing which I didn't 
> like (the floats) and also fixed a bug which appeared when I tried to load 
> games with a novice.  The problem seems to be that update_research was 
> called before the science_rate was properly set.
> 
> Please check the patch.  I think it is ready for inclusion.

I don't like the idea of having a "novice" level (or any other level)
that magically sets some hidden variables.  The original patch had the
right interface, in my opinion.  Better fix this in the other direction
by making the "skill"-influenced variables real variables whose
names start with "ai.".

If there's a lobby to have the "novice" patch on pubserver instead
I'll install it of course.

-- 
Reinier




[Prev in Thread] Current Thread [Next in Thread]