[Freeciv-Dev] Re: suggestion: myth about freeciv

[Raimar Falke <rf13@xxxxxxxxxxxxxxxxx>]

On Fri, Feb 07, 2003 at 06:05:03PM +0100, Andreas Røsdal wrote:
> Raimar Falke wrote:
> 
> >On Thu, Feb 06, 2003 at 11:49:04PM +0100, Andreas Røsdal wrote:
> > 
> >
> >>Hello!
> >>I've been experimenting with scrolling "The Freeciv Myth"
> >>on the introscreen. 
> >>
> >It doesn't compile. At least if some stricter options (like "-Wall
> >-Wpointer-arith -Wcast-align -Wmissing-prototypes
> >-Wmissing-declarations -Werror) are used.
> >
> >I fixed this. Now I got an access for index -1 on the myth array. The
> >assert I inserted triggered. 
> >
> The while-loop in intro_scroll() was off by one.
> It's fixed it in the attached file. Does it compile properly for you now?

Now it doesn't apply clean:
$ patch -p0 <myth3.diff 
patching file client/tilespec.c
patching file client/tilespec.h
patching file client/gui-gtk/graphics.c
patch: **** malformed patch at line 172: Index: client/gui-gtk/graphics.h

> >Also note that the use of _() in
> >freeciv_myth isn't portable: only constants are allowed in
> >initializers.
> >
> How can this best be solved?

Use N_() in the array and change the return line to
  return _(myth[i]);

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 A life? Cool! Where can I download one?