Complete.Org: Mailing Lists: Archives: freeciv-dev: December 2002:
[Freeciv-Dev] Re: (PR#2455) dead functions in GUI interface
Home

[Freeciv-Dev] Re: (PR#2455) dead functions in GUI interface

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: jdorje@xxxxxxxxxxxxxxxxxxxxx
Cc: freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#2455) dead functions in GUI interface
From: "Raimar Falke via RT" <rt@xxxxxxxxxxxxxx>
Date: Thu, 19 Dec 2002 02:27:17 -0800
Reply-to: rt@xxxxxxxxxxxxxx

On Wed, Dec 18, 2002 at 06:11:47PM -0800, Jason Short via RT wrote:
> > > -char *get_report_title(char *report_name);
> > 
> > Used by mui, win32 and xaw. Removed from gtk to make the dialogs
> > smaller IIRC. I suggest moving this function into common code since
> > the implementation is almost equal.
> 
> Ugh.  This function is just a few lines, and can't be unified without
> adding a few lines to the GUIs that use it.
> 
> OTOH it does assure that the translatable strings will be the same.

Why do you think the implementations differ? Yes one calls mystrdup
and the other calls center_string but this are no problems.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "We've all heard that a million monkeys banging on a million typewriters
  will eventually reproduce the entire works of Shakespeare.
  Now, thanks to the Internet, we know this is not true."




[Prev in Thread] Current Thread [Next in Thread]