[Freeciv-Dev] (PR#2455) dead functions in GUI interface

["Jason Short via RT" <rt@xxxxxxxxxxxxxx>]

[rfalke - Wed Dec 18 13:38:01 2002]:

> On Fri, Nov 29, 2002 at 09:46:41PM -0800, Jason Short via RT wrote:
> > 
> > The attached patch removes some dead functions from the GUI interface. 
> > These functions are never called by the client code, and are not
> > implemented for most GUIs.  Some GUIs implement some of them (used
> > internally), and some GUIs have stub implementations.
> > 
> > Without fixes for the GUIs, this is incomplete.  Patches are welcome.
> 
> > -enum Display_color_type get_visual(void);
> 
> What is the status here? Do we support greyscale and/or
> black-and-white displays? There is a message in the xaw client "only
> color displays supported" but no exit.

Hard to tell, since nobody seems to have such a display to test it on.

> > -void free_color_system(void);
> 
> This should stay. It can/should be called from common code.

Sounds good.

> > -char *get_report_title(char *report_name);
> 
> Used by mui, win32 and xaw. Removed from gtk to make the dialogs
> smaller IIRC. I suggest moving this function into common code since
> the implementation is almost equal.

Ugh.  This function is just a few lines, and can't be unified without
adding a few lines to the GUIs that use it.

OTOH it does assure that the translatable strings will be the same.

jason