[Freeciv-Dev] Re: (PR#2587) class and legend data patch -- oops, with patch this time!

["Miguel Farah via RT" <rt@xxxxxxxxxxxxxx>]

 esr@xxxxxxxxxxx via RT [16/12/2002 06:26] dijo/said:
>
>As discussed on the freeciv-data list, this patch adds class attributes for 
>all nations and legend attributes for most.  It adds a few more cities and
>leaders, as well.

Great.

>I considered splitting the Historical category into Historical and Regional,
>but I think that is more likely to stir political argument than just having
>one category.

I disagree slightly with your choice, but I won't start any arguments.

Anyway, I have a few comments here and there, and refer to small
mistakes in the legends:

>[...]
>--- brazilian.ruleset  2002/12/13 18:20:27     1.1
>+++ brazilian.ruleset  2002/12/14 04:07:29
>@@ -2,6 +2,8 @@
> 
> name=_("Brazilian")
> plural=_("?plural:Brazilians")
>+class=_("Modern")
>+legend=_("Brazil was founded as a colony of Brazil but became independent in 
>1822. It is the only country in the New World that has been the seat of a 
>monarchy.")

Brazil was founded as a colony of Portugal.


>[...]
>--- catalan.ruleset    2002/12/13 18:21:44     1.1
>+++ catalan.ruleset    2002/12/14 16:48:27
>@@ -2,6 +2,8 @@
> 
> name=_("Catalan")
> plural=_("?plural:Catalans")
>+class=_("Historical")
>+legend=_("Catalan (aka Catalonia) is the north-eastern-most coastal region of 
>Spain near the southern foot of the Pyrenees.")
> leader="Guifr? el Pil?s", "Ramon Berenguer IV", "Jaume I", "Pere II",
>        "Lluis Companys", "Josep Tarradellas"
> leader_sex="Male", "Male", "Male", "Male",
>@@ -28,6 +30,9 @@
> wonder="A.Smith's Trading Co."
> government="Republic"

I should have provided proper english translations here.

The region(/country/...)'s name is:

Catalunya (in catalan)
Cataluña  (in spanish)
Catalonia (in english)

So the legend should read "Catalunya (aka Catalonia) is the [...]". Or
better yet: "Catalonia (Catalunya in its native language) is the [...]".

 
>+; This city list does not actually correspond to medieval Catalonia,
>+; but rather to the "Catalon dos Pasos" of modern ethnolinguistic
>+; nationalists.

"Catalon dos Pasos" is a wrong translation of "Països Catalans".
The actual name (in english) is "Catalan Countries".


>[...]
>--- chilean.ruleset    2002/12/13 18:22:04     1.1
>+++ chilean.ruleset    2002/12/14 16:34:37
>[...]
>   "Calama", "Arica", "Constituci?n", "Cha?aral", "Cauquenes",
>-  "Puente alto (river, hills)", "Talagante", "Melipilla", "Peumo",
>+  "Puente Alto (river, hills)", "Talagante", "Melipilla", "Peumo",

That's "Puente alto", not "Puente Alto" (I should know, I did the city
list on this ruleset).