Complete.Org: Mailing Lists: Archives: freeciv-dev: December 2002:
[Freeciv-Dev] Re: (PR#2587) class and legend data patch -- oops, with pa
Home

[Freeciv-Dev] Re: (PR#2587) class and legend data patch -- oops, with pa

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: esr@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#2587) class and legend data patch -- oops, with patch this time!
From: "Raimar Falke via RT" <rt@xxxxxxxxxxxxxx>
Date: Mon, 16 Dec 2002 07:00:03 -0800
Reply-to: rt@xxxxxxxxxxxxxx

On Mon, Dec 16, 2002 at 01:22:57AM -0800, esr@xxxxxxxxxxx via RT wrote:
> 
> As discussed on the freeciv-data list, this patch adds class attributes for 
> all nations and legend attributes for most.  It adds a few more cities and
> leaders, as well.
> 
> I considered splitting the Historical category into Historical and Regional,
> but I think that is more likely to stir political argument than just having
> one category.
> 
> This should be applied on top of my previous two data patches, the original
> Barsoom patch and the corrections.

Some style issues:
 - missing _() in Croatian
 - I know BC and AD and had to look CE and BCE up. The code till now
 only uses AD and BC. You also didn't always use (B)CE.
 - wrapping the lines at 75 chars

Just for the record: you can assert that _you_ wrote all the
descriptions and place them under GPL and didn't copied them from a
dictionary?! We had such a case for the help texts of the techs in the
past.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "Many of my assistants were fans of Tolkien, who wrote 'Lord of the Rings'
  and a number of other children's stories for adults.  The first character
  alphabet that was programmed for my plotter was Elvish rather than Latin."
    -- from SAIs "life as a computer for a quarter of a century"




[Prev in Thread] Current Thread [Next in Thread]