[Freeciv-Dev] Re: (PR#2365) gui-gtk: free_sprite doesn't free mask

["Raimar Falke via RT" <rt@xxxxxxxxxxxxxx>]

On Mon, Dec 09, 2002 at 11:22:34AM -0800, Jason Short via RT wrote:
> 
> [rfalke - Fri Dec  6 22:33:11 2002]:
> 
> > IMHO we should solve it in the following way:
> >  - make a rule that all pixmaps are freed by us
> >  - for the imlib pixmaps we clone them after they are created by 
> > imlib with our own functions (ctor_sprite_mask) and free the imlib 
> > one's after this.
> 
> This seems fine, but will potentially slow down the loading of graphics
> since each sprite, once loaded, must be copied.  And I don't know if
> imlib actually does anything useful (faster drawing, etc.) by
> associating the pixmap and its mask.  If it does, then it would make
> more sense to do it the other way around (make all sprites imlib pixmaps).

Doing the copy should be fast (a call to memcpy). Creating more
dependencies to imlib is IMHO bad and not needed. Especially we want
to switch to gdkpixbuf at some point.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "From what I am reading Win98 and NT5.0 will be getting rid of all that
  crap anyway. Seems that Microsoft has invented something called TCP/IP and
  another really revolutionary concept called DNS that eliminates the
  netbios crap too. All that arping from browsers is going to go away.
  I also hear rumors that they are on the verge of breakthrough discoveries
  called NFS, and LPD too. Given enough time and money, they might
  eventually invent Unix."
    -- George Bonser in linux-kernel