[Freeciv-Dev] Re: Civ 2 Style Waste: A RFC

["Per I. Mathisen" <per@xxxxxxxxxxx>]

On Fri, 29 Nov 2002, Raahul Kumar wrote:
> This is an implementation of Civ 2 style waste. Waste is corruption for
> shields. Now cities that are far away from your palace lose not merely trade,
> but also shields. This makes ICS more difficult.

Yes, but not by much. There is still Republic.

Anyway, I'm for it, but I want it configurable through government.ruleset
just like corruption is, so g->corruption_level should be g->waste_level
and so on. We may want to have govts that have little corruption but lots
of waste or the other way around.

> misleading. Your implementation also makes fulltradesize/notradesize affect
> shields. I do not think that is a goodidea.

I agree fully. This makes notradesize much too nasty for anyone to want to
use it.

> So I suggest going with the function city_waste(instead of city_corruption),
> which is further down in this email. What do you think?

Maybe you should put the duplicate code in a separate (static) function
that both city_corruption and city_waste use? But do fix style issues.

>   capital = find_palace(city_owner(pcity));
>   if (!capital)
>     dist = 36;
>   else {
>     int tmp = map_distance(capital->x, capital->y, pcity->x, pcity->y);
>     dist = MIN(36, tmp);

Can someone explain to me the rationale behind this magic limit of 36? I
hate magic limits.

  - Per