[Freeciv-Dev] Re: Civ 2 Style Waste: A RFC

[Raahul Kumar <raahul_da_man@xxxxxxxxx>]

--- "Per I. Mathisen" <per@xxxxxxxxxxx> wrote:

> Anyway, I'm for it, but I want it configurable through government.ruleset
> just like corruption is, so g->corruption_level should be g->waste_level
> and so on. We may want to have govts that have little corruption but lots
> of waste or the other way around.

Odd. It makes sense to me that corruption and waste would go together, but your
wish is my command.  

> I agree fully. This makes notradesize much too nasty for anyone to want to
> use it.

I was thinking of adding noshieldsize/fullshieldsize. Server variables.
 
> Maybe you should put the duplicate code in a separate (static) function
> that both city_corruption and city_waste use? But do fix style issues.

Not sure that makes much sense. I'll end up using misleading names like trade,
trade penalty. Future Freeciv'ers will curse me like we currently curse Syela. 
 
> >   capital = find_palace(city_owner(pcity));
> >   if (!capital)
> >     dist = 36;
> >   else {
> >     int tmp = map_distance(capital->x, capital->y, pcity->x, pcity->y);
> >     dist = MIN(36, tmp);
> 
> Can someone explain to me the rationale behind this magic limit of 36? I
> hate magic limits.

I only know the origin of this limit. Civ 2 did it this way. A Define with a
explanation? Arbitrary max distance limit, because Civ 2 did it this way.

Without a corruption limit, large empires are impossible in governments other
than Democracy.   
 
>   - Per

Aloha,
RK.

Watching a peaceful death of a human being reminds us of a falling star; one of
a million lights in a vast sky that flares up for a brief moment only to
disappear into the endless night forever. -Elisabeth Kuebler-Ross, "On Death
and Dying"

__________________________________________________
Do you Yahoo!?
Yahoo! Mail Plus - Powerful. Affordable. Sign up now.
http://mailplus.yahoo.com