Complete.Org: Mailing Lists: Archives: freeciv-dev: September 2002:
[Freeciv-Dev] Re: coding standard patch
Home

[Freeciv-Dev] Re: coding standard patch

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: "Per I. Mathisen" <per@xxxxxxxxxxx>
Cc: freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: coding standard patch
From: Raimar Falke <rf13@xxxxxxxxxxxxxxxxx>
Date: Mon, 23 Sep 2002 16:03:16 +0200

On Mon, Sep 23, 2002 at 10:22:25AM +0000, Per I. Mathisen wrote:
> On Mon, 23 Sep 2002, Raimar Falke wrote:
> > I agree with you that tabs are bad, BUT indent uses tabs. Only
> > new(est) version of GNU-indent has an option to use spaces instead.
> >
> > If you really want to have them gone I have no problem doing a s/\t/     /
> > over the tree in regular intervalls.
> 
> This has the side-effect of genereting completely unnecessary patch
> conflicts, so I'm against that. At least 

> as long as we still have huge patches waiting to go in

This is a always the case.

> I would much rather have a ban against introducing new tabs in the
> source code, and then eventually the number of tabs in the code will
> slide towards zero as parts of the code gets rewritten and patched.

> Developers that know how to run indent over their patches can also be
> expected to upgrade their indent to a newer version.

You mean I should upgrade?

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "We just typed make..."
    -- Stephen Lambrigh, Director of Server Product Marketing at Informix,
                         about porting their Database to Linux


[Prev in Thread] Current Thread [Next in Thread]