[Freeciv-Dev] Re: [Patch] Cleanup of scorelog generation/new scorelog fo
[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
On Tue, Aug 27, 2002 at 07:50:59PM +0200, Raimar Falke wrote:
[about the new scorelog format]
> > - isn't it better to put the comment text in a separate file,
> > perhaps in data/ ?
> > that way, it's easier to add translation, I think
> I didn't indent to translate it. I just found the idea nice that a
> file documents itself. We can move it to data/ or doc/ but I'm not
> sure if people will find it there. I nice idea is that we put a URL in
> the file for a reference of the format and let it point to some lxr
I think it's nice to have the comment in the file itself; I just wonder
if the C code is the best place to keep the editable source of that comment.
But a URL may be fine, too. (XML already supports this.)
> > for people with small disks it may be better do be a little more
> > space efficient
> We can gzip the file after the game has ended.
It gzips very well.
> > - I'd prefer "player" to "addplayer": that would still be correct
> > if player renaming is ever implemented
> "addplayer" is symetric to "delplayer". If we can renaming I'm for
> adding a "ren(ame)player".
Yes, a "player" tag would also have to be used to delete players.
> > It would be nice to have a standalone sav2scorelog utility distributed
> > with the code.
> You mean a set of saves (generate with saveturns=1) are read in and a
> scorelog is produced? If yes: why? You can just enable the scorelog in
> the first place.
Not if you lack the disk space or forgot to turn it on.
I wrote a sav2score utility long ago and used it often.
> > > About the patch: pretty straightforward. Note that I have removed the
> > > ability to read the old scorelogs.
> > In that case we must provide a conversion script.
> Why? It only matters if the server appends to a scorelog.
You're right, with the new format, the server doesn't need to read
scorelogs in the first place.