[Freeciv-Dev] Re: city report patch ver 3

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Sat, Mar 16, 2002 at 11:32:40PM -0600, Mike Kaufman wrote:
> version 4 up to bat.
> 
> On Sat, Mar 16, 2002 at 02:34:46PM +0100, Raimar Falke wrote:
> > On Sat, Mar 16, 2002 at 12:20:00PM +0100, Christian Knoke wrote:
> > > On Sat, Mar 16, 2002 at 08:55:12AM +0100, Raimar Falke wrote:
> > > > On Fri, Mar 15, 2002 at 11:10:05PM -0600, Mike Kaufman wrote:
> > > > > attached is the third (and last?) go around for this patch
> > > > > 
> > > > > what it does now:
> > > > > - give change/select buildings/units/wonders their own submenus
> > > > > - remove refresh button
> > > > > - move change all button to change menu
> > > > > - add select options for currently building buildings/units/wonders
> > > > > 
> > > > > see what you think.
> > > 
> > > I think: Great!
> > > 
> > > > 
> > > > You now need to select at least one city to use change all.
> > > 
> > > Just deselect all menu items except "Change all" instead of
> > > the deselect the "Change" button?
> > 
> > Ok.
> 
> done.
> 
> > 
> > > > > +#define IMPRS   1
> > > > > +#define WONDERS 2
> > > > > +#define UNITS   3
> > > > 
> > > > Please use an enum.
> 
> yeah, yeah, I had a precognition had you would even use those exact
> words.

It turns out that we already have such enum: 
  common/city.h:enum production_class_type

The rest is ok.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  "With a PC, I always felt limited by the software available.
   On Unix, I am limited by my knowledge."
    -- Peter J. Schoenster <pschon@xxxxxxxxxxxxxxxxx>