[Freeciv-Dev] Re: [Patch] Cleanup of attack power calculations

[Raahul Kumar <raahul_da_man@xxxxxxxxx>]

--- Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx> wrote:
<snip>



<snip>
> -  ptype = unit_type(punit);
> 
> -/* get_attack_power will be wrong if moves_left == 1 || == 2 */
> 
> This means for me: we can't use get_attack_power here because the
> result will be wrong if moves_left<SINGLE_MOVE.
> 

I do not see why. If you attack that turn with that unit, it's attack power
is indeed lower if it has fractional move points.

> base_get_attack_power is called by base_unit_belligerence_primitive is
> called by unit_belligerence_basic with moves_left=SINGLE_MOVE. This
> means that in base_get_attack_power the reduction isn't made.
>

That is exactly why I hate wrapper functions.
 

> > Petr has renamed a lot of variables. Any comments?
> 
> In kill_something_with?

He's hit a lot more functions than that. Most of the alphabet soup has the
same meaning except for m which normally means move_type. I'm going to sleep.
It's 1 am here.
 


__________________________________________________
Do You Yahoo!?
Yahoo! Sports - Coverage of the 2002 Olympic Games
http://sports.yahoo.com