[Freeciv-Dev] Re: [Patch] Cleanup of attack power calculations

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Mon, Feb 25, 2002 at 02:23:25PM -0600, Mike Kaufman wrote:
> On Mon, Feb 25, 2002 at 06:33:33PM +0100, Raimar Falke wrote:
> > 
> > To understand combat.c better I have cleaned up the calculation of the
> > attack power. Best part: you can now tell the differnce between
> > unit_belligerence_basic and unit_belligerence_primitive.
> > 
> >     Raimar
> 
> please explain to me why we need 3 different belligerence functions in the
> first place (with similar sounding names and, of course, no function comment
> headers)

Don't ask me. But this patch makes this comparable. I would rename
  unit_belligerence to unit_belligerence_squared
  unit_belligerence_basic to unit_belligerence_no_move_reduction
  unit_belligerence_primitive to unit_belligerence
based on the patch. But I leave this to other people. I don't have to
live with the names.

        Raimar
-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  "Real Users find the one combination of bizarre
   input values that shuts down the system for days."