[Freeciv-Dev] Re: [Patch] Cleanup of attack power calculations

[Gregory Berkolaiko <Gregory.Berkolaiko@xxxxxxxxxxxx>]

On Tue, 26 Feb 2002, Raimar Falke wrote:
> > > 
> > > > > +      a = base_unit_belligerence_primitive(i, FALSE, SINGLE_MOVE,
> > > > > +                                        unit_types[i].hp);
> > > > 
> > > > why don't you feed 
> > > > (m == LAND_MOVING || player_knows_improvement_tech(pplayer, B_PORT)
> > > > as a parameter to base_unit_belligerence_primitive??
> > > 
> > > It looks like do_make_unit_veteran is the right thing.
> > 
> > no it isn't
> 
> Indead. 
> 
> But this is the only case where this factor would be needed.

what I meant is make new variable
bool will_be_veteran = (m == LAND_MOVING 
                        || player_knows_improvement_tech(pplayer, B_PORT))
and then call
a = base_unit_belligerence_primitive(i, will_be_veteran, 
                                     SINGLE_MOVE, unit_types[i].hp);

instead of

a = base_unit_belligerence_primitive(i, FALSE,
                                     SINGLE_MOVE, unit_types[i].hp);

[...]

> > If you are not prepared to do it properly, then commit the patch, it's an
> > improvement anyway.  Others will finish what you left hanging.
> 
> Ok.

Please add a FIXME then.
It is an error and it should be fixed.

> > P.S. I remember you saying, I quote, "strong indication for me to fix the
> > things if you notice them (even if there aren't part of the original authors
> > intentions)".  It seems you forget what you say...  
> 
> I had this in mind as I said: write down the problems which were
> identified in the todo list.

Good.  So FIXME you would do then.

G.