[Freeciv-Dev] Re: [RFC] [Patch] Unused parameter

[Gregory Berkolaiko <gberkolaiko@xxxxxxxxxxx>]

 --- Raahul Kumar <raahul_da_man@xxxxxxxxx> wrote: 
> --- Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx> wrote:
> > 
> > The attached patch tags unused parameter with "/*@unused@*/" which
> > splint understands. This patch could act as a discussion base and to
> > decide case by case what should happen with the parameter: remove it
> > or keep it. For example the parameters in create_improvements_list,
> > handle_move_unit and notify_about_incoming_packet should be
> > removed. create_help_page should be removed altogether. In some other
> > cases (get_total_attack_power, build_*_time) it indicates some
> > flexibility which was never used. Should this flexibility be kept?
> > 
> >     Raimar
> > 
> > -- 
> >  email: rf13@xxxxxxxxxxxxxxxxx
> 
> 
> > -void attitude_advisor_choose_tech(struct player *pplayer, 
> > +void attitude_advisor_choose_tech( /*@unused@ */ struct player
> *pplayer,
> >                               struct ai_choice *choice)
> 
> I vote for getting rid of all the pplayer structs. There's no advantage
> to
> keeping it in the AI code. 

Ideally the choices would depend on the pplayer's personality
(civilized/not etc).  However it should probably come in on a higher
level, when the player decides which advisor he is going to listen to.

G.

__________________________________________________
Do You Yahoo!?
Everything you'll ever need on one web page
from News and Sport to Email and Music Charts
http://uk.my.yahoo.com