[Freeciv-Dev] Re: New Patch

["Alexander Mai" <st002279@xxxxxxxxxxxxxxxxxxxxxx>]

On Wed, 6 Feb 2002 22:28:41 +0000 (WET), Vasco Alexandre Da Silva Costa wrote:

>Printing a size_t as a long isn't fullproof either. Nothing prevents a
>future machine from having a 128-bit addressing space, and long isn't
>garanteed to be the same size as a size_t. Only >= size of int.
>
>(Yes i know a 128-bit addressing space sounds too big to even imagine, but
>remember, 640Kb is enough for everyone).
>
>The cast to int Raimar used is a valid solution since the size of his
>struct fits in an int, and since this is just for a freelog function it
>wouldn't be too important if it didn't either.
>
>I would prefer if it was casted to an unsigned instead of an int though.
>But that doesn't matter in this case.

Well, not wrong but that's a minor effect compared
to "long vs. int".
Anything beyond can't be done anyway since "(unsigned) long long"
is not in C89.

So, would be nice if my patch (or better) goes in now, to
fix the warning on my and other systems...


---
Alexander Mai
st002279@xxxxxxxxxxxxxxxxxxxxxx