Complete.Org: Mailing Lists: Archives: freeciv-dev: February 2002:
[Freeciv-Dev] [RFC] [Patch] Unused parameter
Home

[Freeciv-Dev] [RFC] [Patch] Unused parameter

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: freeciv development list <freeciv-dev@xxxxxxxxxxx>
Subject: [Freeciv-Dev] [RFC] [Patch] Unused parameter
From: Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>
Date: Tue, 5 Feb 2002 16:51:42 +0100
Reply-to: rf13@xxxxxxxxxxxxxxxxxxxxxx

The attached patch tags unused parameter with "/*@unused@*/" which
splint understands. This patch could act as a discussion base and to
decide case by case what should happen with the parameter: remove it
or keep it. For example the parameters in create_improvements_list,
handle_move_unit and notify_about_incoming_packet should be
removed. create_help_page should be removed altogether. In some other
cases (get_total_attack_power, build_*_time) it indicates some
flexibility which was never used. Should this flexibility be kept?

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "Reality? That's where the pizza delivery guy comes from!"

Attachment: unused_parameter1.diff
Description: Text document


[Prev in Thread] Current Thread [Next in Thread]