? diff ? out ? unused_parameter1.diff ? splint_weak ? files_to_check ? null_cmp1.diff Index: ai/advattitude.c =================================================================== RCS file: /home/freeciv/CVS/freeciv/ai/advattitude.c,v retrieving revision 1.3 diff -u -r1.3 advattitude.c --- ai/advattitude.c 2000/03/04 03:55:26 1.3 +++ ai/advattitude.c 2002/02/05 15:42:10 @@ -25,7 +25,7 @@ the moment ***********************************************************************/ -void attitude_advisor_choose_tech(struct player *pplayer, +void attitude_advisor_choose_tech( /*@unused@ */ struct player *pplayer, struct ai_choice *choice) { choice->choice = A_NONE; Index: ai/advforeign.c =================================================================== RCS file: /home/freeciv/CVS/freeciv/ai/advforeign.c,v retrieving revision 1.3 diff -u -r1.3 advforeign.c --- ai/advforeign.c 2000/03/04 03:55:26 1.3 +++ ai/advforeign.c 2002/02/05 15:42:10 @@ -25,7 +25,7 @@ the moment ***********************************************************************/ -void foreign_advisor_choose_tech(struct player *pplayer, +void foreign_advisor_choose_tech( /*@unused@ */ struct player *pplayer, struct ai_choice *choice) { choice->choice = A_NONE; Index: ai/advisland.c =================================================================== RCS file: /home/freeciv/CVS/freeciv/ai/advisland.c,v retrieving revision 1.4 diff -u -r1.4 advisland.c --- ai/advisland.c 2001/12/11 16:16:25 1.4 +++ ai/advisland.c 2002/02/05 15:42:11 @@ -22,8 +22,9 @@ ... add some interesting adjustments here according to island status **********************************************************************/ -void island_adjust_build_choice(struct player *pplayer, - struct ai_choice *choice, int advisor) +void island_adjust_build_choice( /*@unused@ */ struct player *pplayer, + struct ai_choice *choice, + /*@unused@ */ int advisor) { adjust_choice(100, choice); /* this function haven't been implemented yet */ Index: ai/advmilitary.c =================================================================== RCS file: /home/freeciv/CVS/freeciv/ai/advmilitary.c,v retrieving revision 1.82 diff -u -r1.82 advmilitary.c --- ai/advmilitary.c 2002/01/29 22:06:14 1.82 +++ ai/advmilitary.c 2002/02/05 15:42:11 @@ -36,7 +36,7 @@ if choice is A_NONE this advisor doesn't want any tech researched at the moment ***********************************************************************/ -void military_advisor_choose_tech(struct player *pplayer, +void military_advisor_choose_tech( /*@unused@ */ struct player *pplayer, struct ai_choice *choice) { choice->choice = A_NONE; Index: ai/advscience.c =================================================================== RCS file: /home/freeciv/CVS/freeciv/ai/advscience.c,v retrieving revision 1.3 diff -u -r1.3 advscience.c --- ai/advscience.c 2000/03/04 03:55:26 1.3 +++ ai/advscience.c 2002/02/05 15:42:12 @@ -25,7 +25,7 @@ the moment ***********************************************************************/ -void science_advisor_choose_tech(struct player *pplayer, +void science_advisor_choose_tech( /*@unused@ */ struct player *pplayer, struct ai_choice *choice) { choice->choice = A_NONE; Index: ai/advtrade.c =================================================================== RCS file: /home/freeciv/CVS/freeciv/ai/advtrade.c,v retrieving revision 1.3 diff -u -r1.3 advtrade.c --- ai/advtrade.c 2000/03/04 03:55:26 1.3 +++ ai/advtrade.c 2002/02/05 15:42:12 @@ -25,7 +25,8 @@ the moment ***********************************************************************/ -void trade_advisor_choose_tech(struct player *pplayer, struct ai_choice *choice) +void trade_advisor_choose_tech( /*@unused@ */ struct player *pplayer, + struct ai_choice *choice) { choice->choice = A_NONE; choice->want = 0; Index: client/civclient.c =================================================================== RCS file: /home/freeciv/CVS/freeciv/client/civclient.c,v retrieving revision 1.107 diff -u -r1.107 civclient.c --- client/civclient.c 2002/02/02 10:01:29 1.107 +++ client/civclient.c 2002/02/05 15:42:12 @@ -592,7 +592,7 @@ } void dealloc_id(int id); /* double kludge (suppress a possible warning) */ -void dealloc_id(int id) { }/* kludge */ +void dealloc_id( /*@unused@ */ int id) { }/* kludge */ /************************************************************************** .. Index: client/clinet.c =================================================================== RCS file: /home/freeciv/CVS/freeciv/client/clinet.c,v retrieving revision 1.52 diff -u -r1.52 clinet.c --- client/clinet.c 2002/02/02 09:21:31 1.52 +++ client/clinet.c 2002/02/05 15:42:13 @@ -320,7 +320,7 @@ This function is called when the client received a new input from the server. **************************************************************************/ -void input_from_server(int fid) +void input_from_server( /*@unused@ */ int fid) { if (read_from_connection(&aconnection, 0) >= 0) { int type, result; @@ -345,7 +345,7 @@ the PACKET_PROCESSING_FINISHED packet for the given request is received. **************************************************************************/ -void input_from_server_till_request_got_processed(int fd, +void input_from_server_till_request_got_processed( /*@unused@ */ int fd, int expected_request_id) { assert(expected_request_id); Index: client/packhand.c =================================================================== RCS file: /home/freeciv/CVS/freeciv/client/packhand.c,v retrieving revision 1.209 diff -u -r1.209 packhand.c --- client/packhand.c 2002/02/02 09:21:31 1.209 +++ client/packhand.c 2002/02/05 15:42:14 @@ -492,8 +492,9 @@ /************************************************************************** ... **************************************************************************/ -static void handle_city_packet_common(struct city *pcity, int is_new, - int popup, int investigate) +static void handle_city_packet_common(struct city *pcity, int is_new, + int popup, + /*@unused@ */ int investigate) { int i; @@ -816,7 +817,7 @@ /************************************************************************** ... **************************************************************************/ -void handle_move_unit(struct packet_move_unit *packet) +void handle_move_unit(/*@unused@ */ struct packet_move_unit *packet) { /* this packet should never get sent to a client */ assert(0); @@ -2326,7 +2327,7 @@ /************************************************************************** ... **************************************************************************/ -void notify_about_incoming_packet(struct connection *pc, +void notify_about_incoming_packet(/*@unused@ */ struct connection *pc, int packet_type, int size) { freelog(LOG_DEBUG, "incoming packet={type=%d, size=%d}", packet_type, @@ -2336,7 +2337,7 @@ /************************************************************************** ... **************************************************************************/ -void notify_about_outgoing_packet(struct connection *pc, +void notify_about_outgoing_packet(/*@unused@ */ struct connection *pc, int packet_type, int size, int request_id) { Index: client/tilespec.c =================================================================== RCS file: /home/freeciv/CVS/freeciv/client/tilespec.c,v retrieving revision 1.59 diff -u -r1.59 tilespec.c --- client/tilespec.c 2002/01/06 16:43:25 1.59 +++ client/tilespec.c 2002/02/05 15:42:15 @@ -1104,7 +1104,7 @@ ***********************************************************************/ int fill_tile_sprite_array_iso(struct Sprite **sprs, struct Sprite **coasts, struct Sprite **dither, - int x, int y, int citymode, + int x, int y, /*@unused@ */ int citymode, int *solid_bg) { int ttype, ttype_near[8]; Index: client/gui-gtk/citydlg.c =================================================================== RCS file: /home/freeciv/CVS/freeciv/client/gui-gtk/citydlg.c,v retrieving revision 1.110 diff -u -r1.110 citydlg.c --- client/gui-gtk/citydlg.c 2002/02/02 09:21:34 1.110 +++ client/gui-gtk/citydlg.c 2002/02/05 15:42:18 @@ -537,7 +537,7 @@ **info_label points to the info_label in the respective struct ****************************************************************/ static GtkWidget *create_city_info_table(GtkWidget ** info_label, - struct city_dialog *pdialog) + /*@unused@ */ struct city_dialog *pdialog) { int i; GtkWidget *hbox, *table, *label; Index: client/gui-gtk/cityrep.c =================================================================== RCS file: /home/freeciv/CVS/freeciv/client/gui-gtk/cityrep.c,v retrieving revision 1.47 diff -u -r1.47 cityrep.c --- client/gui-gtk/cityrep.c 2002/02/02 09:21:34 1.47 +++ client/gui-gtk/cityrep.c 2002/02/05 15:42:19 @@ -525,7 +525,7 @@ /**************************************************************** ... *****************************************************************/ -static void create_city_report_dialog(int make_modal) +static void create_city_report_dialog(/*@unused@ */ int make_modal) { static char *titles [NUM_CREPORT_COLS]; static char buf [NUM_CREPORT_COLS][64]; Index: client/gui-gtk/dialogs.c =================================================================== RCS file: /home/freeciv/CVS/freeciv/client/gui-gtk/dialogs.c,v retrieving revision 1.80 diff -u -r1.80 dialogs.c --- client/gui-gtk/dialogs.c 2001/12/21 16:26:38 1.80 +++ client/gui-gtk/dialogs.c 2002/02/05 15:42:21 @@ -676,7 +676,8 @@ ... *****************************************************************/ static int create_advances_list(struct player *pplayer, - struct player *pvictim, int make_modal) + struct player *pvictim, + /*@unused@ */ int make_modal) { GtkWidget *close_command, *scrolled; int i, j; @@ -773,8 +774,9 @@ /**************************************************************** ... *****************************************************************/ -static int create_improvements_list(struct player *pplayer, - struct city *pcity, int make_modal) +static int create_improvements_list(/*@unused@ */ struct player *pplayer, + struct city *pcity, + /*@unused@ */ int make_modal) { GtkWidget *close_command, *scrolled; int i, j; Index: client/gui-gtk/gui_main.c =================================================================== RCS file: /home/freeciv/CVS/freeciv/client/gui-gtk/gui_main.c,v retrieving revision 1.95 diff -u -r1.95 gui_main.c --- client/gui-gtk/gui_main.c 2002/01/28 04:41:39 1.95 +++ client/gui-gtk/gui_main.c 2002/02/05 15:42:22 @@ -160,7 +160,7 @@ Print extra usage information, including one line help on each option, to stderr. **************************************************************************/ -static void print_usage(const char *argv0) +static void print_usage(/*@unused@ */ const char *argv0) { /* add client-specific usage information here */ fprintf(stderr, _("Report bugs to <%s>.\n"), BUG_EMAIL_ADDRESS); @@ -1067,7 +1067,9 @@ /************************************************************************** ... **************************************************************************/ -static void get_net_input(gpointer data, gint fid, GdkInputCondition condition) +static void get_net_input(/*@unused@ */ gpointer data, + gint fid, + /*@unused@ */ GdkInputCondition condition) { input_from_server(fid); } @@ -1075,7 +1077,7 @@ /************************************************************************** ... **************************************************************************/ -static void set_wait_for_writable_socket(struct connection *pc, +static void set_wait_for_writable_socket(/*@unused@ */ struct connection *pc, int socket_writable) { static int previous_state = 0; Index: client/gui-gtk/helpdlg.c =================================================================== RCS file: /home/freeciv/CVS/freeciv/client/gui-gtk/helpdlg.c,v retrieving revision 1.47 diff -u -r1.47 helpdlg.c --- client/gui-gtk/helpdlg.c 2002/01/21 10:16:18 1.47 +++ client/gui-gtk/helpdlg.c 2002/02/05 15:42:22 @@ -635,7 +635,7 @@ /************************************************************************** ... **************************************************************************/ -static void create_help_page(enum help_page_type type) +static void create_help_page(/*@unused@ */ enum help_page_type type) { } @@ -643,7 +643,7 @@ ... **************************************************************************/ static void help_update_improvement(const struct help_item *pitem, - char *title, int which) + /*@unused@ */ char *title, int which) { char *buf = &long_buffer[0]; @@ -683,7 +683,7 @@ ... **************************************************************************/ static void help_update_wonder(const struct help_item *pitem, - char *title, int which) + /*@unused@ */ char *title, int which) { char *buf = &long_buffer[0]; @@ -722,7 +722,7 @@ ... **************************************************************************/ static void help_update_unit_type(const struct help_item *pitem, - char *title, int i) + /*@unused@ */ char *title, int i) { char *buf = &long_buffer[0]; @@ -794,7 +794,8 @@ /************************************************************************** ... **************************************************************************/ -static void help_update_tech(const struct help_item *pitem, char *title, int i) +static void help_update_tech(const struct help_item *pitem, + /*@unused@ */ char *title, int i) { int j; GtkWidget *w, *hbox; @@ -911,7 +912,7 @@ ... **************************************************************************/ static void help_update_terrain(const struct help_item *pitem, - char *title, int i) + /*@unused@ */ char *title, int i) { char *buf = &long_buffer[0]; @@ -1039,7 +1040,8 @@ This is currently just a text page, with special text: **************************************************************************/ static void help_update_government(const struct help_item *pitem, - char *title, struct government *gov) + /*@unused@ */ char *title, + struct government *gov) { char *buf = &long_buffer[0]; Index: client/gui-gtk/mapview.c =================================================================== RCS file: /home/freeciv/CVS/freeciv/client/gui-gtk/mapview.c,v retrieving revision 1.111 diff -u -r1.111 mapview.c --- client/gui-gtk/mapview.c 2001/12/21 19:14:18 1.111 +++ client/gui-gtk/mapview.c 2002/02/05 15:42:24 @@ -1793,7 +1793,7 @@ Only used for isometric view. **************************************************************************/ static void really_draw_segment(int src_x, int src_y, int dir, - int write_to_screen, int force) + int write_to_screen, /*@unused@ */ int force) { int dest_x, dest_y, is_real; int canvas_start_x, canvas_start_y; Index: client/gui-gtk/repodlgs.c =================================================================== RCS file: /home/freeciv/CVS/freeciv/client/gui-gtk/repodlgs.c,v retrieving revision 1.46 diff -u -r1.46 repodlgs.c --- client/gui-gtk/repodlgs.c 2002/02/02 09:55:37 1.46 +++ client/gui-gtk/repodlgs.c 2002/02/05 15:42:24 @@ -146,7 +146,7 @@ /**************************************************************** ... *****************************************************************/ -void create_science_dialog(int make_modal) +void create_science_dialog(/*@unused@ */ int make_modal) { GtkWidget *close_command; GtkWidget *frame, *hbox, *w; @@ -562,7 +562,7 @@ /**************************************************************** ... *****************************************************************/ -void create_economy_report_dialog(int make_modal) +void create_economy_report_dialog(/*@unused@ */ int make_modal) { GtkWidget *close_command, *scrolled; static gchar *titles_[4] = { N_("Building Name"), N_("Count"), @@ -815,7 +815,7 @@ /**************************************************************** ... *****************************************************************/ -void create_activeunits_report_dialog(int make_modal) +void create_activeunits_report_dialog(/*@unused@ */ int make_modal) { GtkWidget *close_command, *refresh_command; static gchar *titles_[AU_COL] Index: common/combat.c =================================================================== RCS file: /home/freeciv/CVS/freeciv/common/combat.c,v retrieving revision 1.9 diff -u -r1.9 combat.c --- common/combat.c 2001/09/15 15:31:24 1.9 +++ common/combat.c 2002/02/05 15:42:25 @@ -282,7 +282,8 @@ return the modified attack power of a unit. Currently they aren't any modifications... ***************************************************************************/ -int get_total_attack_power(struct unit *attacker, struct unit *defender) +int get_total_attack_power(struct unit *attacker, + /*@unused@ */ struct unit *defender) { int attackpower = get_attack_power(attacker); Index: common/map.c =================================================================== RCS file: /home/freeciv/CVS/freeciv/common/map.c,v retrieving revision 1.103 diff -u -r1.103 map.c --- common/map.c 2001/12/13 19:13:16 1.103 +++ common/map.c 2002/02/05 15:42:26 @@ -726,7 +726,7 @@ /*************************************************************** ... ***************************************************************/ -int map_build_rail_time(int x, int y) +int map_build_rail_time(/*@unused@ */ int x, /*@unused@ */ int y) { return 3; } @@ -734,7 +734,7 @@ /*************************************************************** ... ***************************************************************/ -int map_build_airbase_time(int x, int y) +int map_build_airbase_time(/*@unused@ */ int x, /*@unused@ */ int y) { return 3; } @@ -742,7 +742,7 @@ /*************************************************************** ... ***************************************************************/ -int map_build_fortress_time(int x, int y) +int map_build_fortress_time(/*@unused@ */ int x, /*@unused@ */ int y) { return 3; } @@ -750,7 +750,7 @@ /*************************************************************** ... ***************************************************************/ -int map_clean_pollution_time(int x, int y) +int map_clean_pollution_time(/*@unused@ */ int x, /*@unused@ */ int y) { return 3; } @@ -758,7 +758,7 @@ /*************************************************************** ... ***************************************************************/ -int map_clean_fallout_time(int x, int y) +int map_clean_fallout_time(/*@unused@ */ int x, /*@unused@ */ int y) { return 3; } Index: common/tech.c =================================================================== RCS file: /home/freeciv/CVS/freeciv/common/tech.c,v retrieving revision 1.39 diff -u -r1.39 tech.c --- common/tech.c 2002/02/02 09:55:39 1.39 +++ common/tech.c 2002/02/05 15:42:27 @@ -543,7 +543,7 @@ Returns true if the costs for the given technology will stay constant during the game. False otherwise. **************************************************************************/ -int tech_has_fixed_cost(Tech_Type_id tech) +int tech_has_fixed_cost(/*@unused@ */ Tech_Type_id tech) { return ((game.rgame.tech_cost_style == 1 || game.rgame.tech_cost_style == 2) Index: common/unittype.c =================================================================== RCS file: /home/freeciv/CVS/freeciv/common/unittype.c,v retrieving revision 1.9 diff -u -r1.9 unittype.c --- common/unittype.c 2001/12/11 16:16:39 1.9 +++ common/unittype.c 2002/02/05 15:42:27 @@ -310,7 +310,7 @@ /************************************************************************** ... **************************************************************************/ -int unit_upgrade_price(struct player *pplayer, Unit_Type_id from, +int unit_upgrade_price(/*@unused@ */ struct player *pplayer, Unit_Type_id from, Unit_Type_id to) { int total, build; Index: server/barbarian.c =================================================================== RCS file: /home/freeciv/CVS/freeciv/server/barbarian.c,v retrieving revision 1.40 diff -u -r1.40 barbarian.c --- server/barbarian.c 2001/12/11 16:16:47 1.40 +++ server/barbarian.c 2002/02/05 15:42:28 @@ -180,7 +180,7 @@ The return value indicates if the explorer survived entering the vilage. **************************************************************************/ -int unleash_barbarians(struct player* victim, int x, int y) +int unleash_barbarians(/*@unused@ */ struct player* victim, int x, int y) { struct player *barbarians; int unit, unit_cnt, land_cnt=0, sea_cnt=0; Index: server/diplhand.c =================================================================== RCS file: /home/freeciv/CVS/freeciv/server/diplhand.c,v retrieving revision 1.52 diff -u -r1.52 diplhand.c --- server/diplhand.c 2001/09/21 20:04:29 1.52 +++ server/diplhand.c 2002/02/05 15:42:28 @@ -384,7 +384,7 @@ /************************************************************************** ... **************************************************************************/ -void handle_diplomacy_remove_clause(struct player *pplayer, +void handle_diplomacy_remove_clause(/*@unused@ */ struct player *pplayer, struct packet_diplomacy_info *packet) { struct Treaty *ptreaty; @@ -411,7 +411,7 @@ /************************************************************************** ... **************************************************************************/ -void handle_diplomacy_create_clause(struct player *pplayer, +void handle_diplomacy_create_clause(/*@unused@ */ struct player *pplayer, struct packet_diplomacy_info *packet) { struct Treaty *ptreaty; @@ -502,7 +502,7 @@ /************************************************************************** ... **************************************************************************/ -void handle_diplomacy_init(struct player *pplayer, +void handle_diplomacy_init(/*@unused@ */ struct player *pplayer, struct packet_diplomacy_info *packet) { struct packet_diplomacy_info pa; Index: server/mapgen.c =================================================================== RCS file: /home/freeciv/CVS/freeciv/server/mapgen.c,v retrieving revision 1.82 diff -u -r1.82 mapgen.c --- server/mapgen.c 2002/01/13 18:24:44 1.82 +++ server/mapgen.c 2002/02/05 15:42:30 @@ -1438,7 +1438,7 @@ long int totalmass; }; -static int is_cold(int x, int y){ +static int is_cold(/*@unused@ */ int x, int y){ return ( y * 5 < map.ysize || y * 5 > map.ysize * 4 ); } Index: server/plrhand.c =================================================================== RCS file: /home/freeciv/CVS/freeciv/server/plrhand.c,v retrieving revision 1.207 diff -u -r1.207 plrhand.c --- server/plrhand.c 2002/01/21 10:16:23 1.207 +++ server/plrhand.c 2002/02/05 15:42:31 @@ -1803,7 +1803,7 @@ The client request an attribute block. **************************************************************************/ void handle_player_attribute_block(struct player *pplayer, - struct packet_player_request *packet) + /*@unused@ */ struct packet_player_request *packet) { send_attribute_block(pplayer, pplayer->current_conn); } Index: server/settlers.c =================================================================== RCS file: /home/freeciv/CVS/freeciv/server/settlers.c,v retrieving revision 1.115 diff -u -r1.115 settlers.c --- server/settlers.c 2001/12/06 11:59:07 1.115 +++ server/settlers.c 2002/02/05 15:42:33 @@ -390,7 +390,7 @@ /************************************************************************** ... **************************************************************************/ -void ai_manage_settler(struct player *pplayer, struct unit *punit) +void ai_manage_settler(/*@unused@ */ struct player *pplayer, struct unit *punit) { punit->ai.control = 1; if (punit->ai.ai_role == AIUNIT_NONE) /* if BUILD_CITY must remain BUILD_CITY */ @@ -787,7 +787,7 @@ /************************************************************************** simply puts the settler unit into goto **************************************************************************/ -int auto_settler_do_goto(struct player *pplayer, struct unit *punit, int x, int y) +int auto_settler_do_goto(/*@unused@ */ struct player *pplayer, struct unit *punit, int x, int y) { nearest_real_pos(&x, &y); punit->goto_dest_x = x; @@ -851,7 +851,8 @@ /************************************************************************** ... **************************************************************************/ -static void consider_settler_action(struct player *pplayer, enum unit_activity act, +static void consider_settler_action(/*@unused@ */ struct player *pplayer, + enum unit_activity act, int extra, int newv, int oldv, int in_use, int d, int *best_newv, int *best_oldv, int *best_act, int *gx, int *gy, int x, int y) Index: server/stdinhand.c =================================================================== RCS file: /home/freeciv/CVS/freeciv/server/stdinhand.c,v retrieving revision 1.198 diff -u -r1.198 stdinhand.c --- server/stdinhand.c 2002/01/07 21:13:07 1.198 +++ server/stdinhand.c 2002/02/05 15:42:35 @@ -1845,7 +1845,7 @@ /************************************************************************** ... **************************************************************************/ -static void rename_player(struct connection *caller, char *arg) +static void rename_player(struct connection *caller, /*@unused@ */ char *arg) { generic_not_implemented(caller, "rename"); } @@ -1953,7 +1953,7 @@ ... ('caller' argument is unused) **************************************************************************/ -static void write_command(struct connection *caller, char *arg) +static void write_command(/*@unused@ */ struct connection *caller, char *arg) { write_init_script(arg); } Index: server/unittools.c =================================================================== RCS file: /home/freeciv/CVS/freeciv/server/unittools.c,v retrieving revision 1.149 diff -u -r1.149 unittools.c --- server/unittools.c 2002/01/21 10:16:24 1.149 +++ server/unittools.c 2002/02/05 15:42:37 @@ -581,7 +581,8 @@ move points are trivial, only modifiers to the base value is if it's sea units and the player has certain wonders/techs ***************************************************************************/ -static void unit_restore_movepoints(struct player *pplayer, struct unit *punit) +static void unit_restore_movepoints(/*@unused@ */ struct player *pplayer, + struct unit *punit) { punit->moves_left=unit_move_rate(punit); }