[Freeciv-Dev] Re: [PATCH] switch default tileset to trident (PR#1219)

[jdorje@xxxxxxxxxxxxxxxxxxxxx]

Ross W. Wetmore wrote:


> At some point this should probably look something like this. This
> would use isometric view with an isometric map and trident with a
> standard map.
>
> +  if (isometric_view_supported() && get_maptype(MAP_TYPE_ISO)) {
> -  if (isometric_view_supported()) {
>      tileset_default = "hires";    /* Do not i18n! --dwp */
>    } else {
>      tileset_default = "trident";    /* Do not i18n! --dwp */
>    }
Isn't the tileset loaded on startup?  We won't know what the map is when 
we're loading it.  Or maybe we don't load it until we connect, in which 
case this change would be excellent.
What can and should certainly be done is to add code to the enhanced 
connection dialog to automatically set the type of the game to match the 
tileset; i.e. if we're using an iso-view tileset switch to an 
iso-rectangular map.

> I'll leave you to figure out if you just want to dummy the extra
> condition to always force trident, or remove all this now and put
> most of it back later.
"all"?  "most"?  We're talking about one line here, right? :-)


jason