[Freeciv-Dev] Re: [PATCH] switch default tileset to trident (PR#1219)

["Ross W. Wetmore" <rwetmore@xxxxxxxxxxxx>]

At 03:54 PM 02/01/12 -0800, jdorje@xxxxxxxxxxxxxxxxxxxxx wrote:
>Ross W. Wetmore wrote:
>
>> At some point this should probably look something like this. This
>> would use isometric view with an isometric map and trident with a
>> standard map.
>> 
>> +  if (isometric_view_supported() && get_maptype(MAP_TYPE_ISO)) {
>> -  if (isometric_view_supported()) {
>>      tileset_default = "hires";    /* Do not i18n! --dwp */
>>    } else {
>>      tileset_default = "trident";    /* Do not i18n! --dwp */
>>    }
>
>Isn't the tileset loaded on startup?  We won't know what the map is when 
>we're loading it.  Or maybe we don't load it until we connect, in which 
>case this change would be excellent.

This is done right before it launches the GUI. It looks like all the
game init stuff has been done, but I have no idea whether it has
actually received enough information in start packets to determine
map type yet. 

But this doesn't seem like a hard thing to do if it is missing. And 
map type will need to sent to it anyway at some point if the topology
stuff ever gets far enough to make it possible.

Even an rcfile preference for the basic view/expected maptype might be nice 
over a hardcoded default though. It would cut down on the number of times
this code changed because the voting public switched majorities :-).

>What can and should certainly be done is to add code to the enhanced 
>connection dialog to automatically set the type of the game to match the 
>tileset; i.e. if we're using an iso-view tileset switch to an 
>iso-rectangular map.

I think any client can force choose the tileset they want. This is so
you don't have to create shell functions to preset things the right 
way for "your" tastes. And maybe partly for Freeciv to show off its
best tilesets if you don't yet know how to choose.

The server (will) choose maptype based on its startup commands, the 
clients can like it or lump it :-).

>> I'll leave you to figure out if you just want to dummy the extra
>> condition to always force trident, or remove all this now and put
>> most of it back later.
>"all"?  "most"?  We're talking about one line here, right? :-)

All of the if-block was removed in Mike's patch.

>jason

Cheers,
RossW
=====