[Freeciv-Dev] Re: Changing interface for generate_warmap (PR#1108)

[Gregory Berkolaiko <gberkolaiko@xxxxxxxxxxx>]

 --- Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx> wrote: 
> On Fri, Dec 14, 2001 at 11:55:37AM +0000, Gregory Berkolaiko wrote:

> > Mea culpa.  I should not use direct access to warmap.
> 
> You can catch these if you remove the global variable.

If you remove it altogether, which is difficult.


> > 5000:
> > =================
> >   if (*ferryboat)
> >     generate_warmap(NULL, punit->x, punit->y, *ferryboat,5000);
> > 
> >   generate_warmap(NULL, punit->x, punit->y, punit,5001);
> > =================
> > You see, first call generates sea-map.  
> 
> > Second call generates land-map and _overwrites_ the id of the
> > sea-map.
> 
> And know it is ugly but not _this_ ugly.

It is not ugly and perfectly reasonable in this particular situation,
given the underlying structure of the warmap.

G.


__________________________________________________
Do You Yahoo!?
Everything you'll ever need on one web page
from News and Sport to Email and Music Charts
http://uk.my.yahoo.com