[Freeciv-Dev] Re: Cleaning up gotohand.c (PR#1068)

[Petr Baudis <pasky@xxxxxxxxxxx>]

> > >          if (map_get_terrain(x1, y1) == T_OCEAN) {
> > > +   /* attempting to walk on water.  Can do if there is a boat there */
> > >            if (punit && ground_unit_transporter_capacity(x1, y1, pplayer) 
> > > > 0)
> > 
> > Nit-picking: Either you write sentences: "The unit attempts to walk on
> > water. Can do if there is a boat there." or prompts "attempting to
> > walk on water; can do if there is a boat there".
> 
> Truly a nit-pick... Ok if the author is happy to fix it but I think it
> would be _really_ bad if this kind of criticism makes people comment
> less or code less...
Well, if Raimar doesn't like that (i don't too, but I wouldn't disapprove the
whole patch for that reason), it should be imho easy for him to fix that by
himself, and don't bother author with those details.

> > > -   /* NOT c = 1 (Syela) [why not? - Thue] */
> > > -   move_cost = (ptile->move_cost[dir] ? SINGLE_MOVE : 0);
> > > +   /* NOT move_cost = MOVE_COST_ROAD (Syela) [why not? - Thue] 
> > > +    * possibly because if an igter unit reuses warmap of a city 
> > > +    * (see generate_warmap), it won't be THAT much different 
> > > +    * from the correct warmap.  For consistency we should have 
> > > +    * SINGLE_MOVE for disembarking igter unit too -- GB */
> > 
> > No. Please don't write novels in comments. Especially if they start
> > with "possibly".
> 
> Why not? Really???
> I think it's ok...
I think so too. More comments == better, if it won't affect code readability
(in negative way ;-).

-- 

                                Petr "Pasky" Baudis

UN*X programmer, UN*X administrator, hobbies = IPv6, IRC, FreeCiv hacking
.
  "A common mistake that people make, when trying to design
   something completely foolproof is to underestimate the
   ingenuity of complete fools."
     -- Douglas Adams in Mostly Harmless
.
Public PGP key, geekcode and stuff: http://pasky.ji.cz/~pasky/