Complete.Org: Mailing Lists: Archives: freeciv-dev: November 2001:
[Freeciv-Dev] Re: Cleaning up gotohand.c (PR#1068)
Home

[Freeciv-Dev] Re: Cleaning up gotohand.c (PR#1068)

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Daniel Sjölie <deepone@xxxxxxxxxx>, rf13@xxxxxxxxxxxxxxxxxxxxxx
Cc: Gregory Berkolaiko <gberkolaiko@xxxxxxxxxxx>, freeciv-dev@xxxxxxxxxxx, bugs@xxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: Cleaning up gotohand.c (PR#1068)
From: Andrew Sutton <ansutton@xxxxxxx>
Date: Fri, 30 Nov 2001 09:31:43 -0500

> > > -   /* NOT c = 1 (Syela) [why not? - Thue] */
> > > -   move_cost = (ptile->move_cost[dir] ? SINGLE_MOVE : 0);
> > > +   /* NOT move_cost = MOVE_COST_ROAD (Syela) [why not? - Thue]
> > > +    * possibly because if an igter unit reuses warmap of a city
> > > +    * (see generate_warmap), it won't be THAT much different
> > > +    * from the correct warmap.  For consistency we should have
> > > +    * SINGLE_MOVE for disembarking igter unit too -- GB */
> >
> > No. Please don't write novels in comments. Especially if they start
> > with "possibly".
>
> Why not? Really???
> I think it's ok...

i'd agree with daniel. comments don't make code worse, or less readable. 
although, it would be nice if the comments were a little more understandable 
than "NOT move_cost = ....".

andy


[Prev in Thread] Current Thread [Next in Thread]