[Freeciv-Dev] Re: Cleaning up gotohand.c (PR#1068)

[Daniel Sjölie <deepone@xxxxxxxxxx>]

On 2001-11-30 14:25:18, Raimar Falke wrote:
> >          if (map_get_terrain(x1, y1) == T_OCEAN) {
> > +     /* attempting to walk on water.  Can do if there is a boat there */
> >            if (punit && ground_unit_transporter_capacity(x1, y1, pplayer) > 
> > 0)
> 
> Nit-picking: Either you write sentences: "The unit attempts to walk on
> water. Can do if there is a boat there." or prompts "attempting to
> walk on water; can do if there is a boat there".

Truly a nit-pick... Ok if the author is happy to fix it but I think it
would be _really_ bad if this kind of criticism makes people comment
less or code less...

> > -     /* NOT c = 1 (Syela) [why not? - Thue] */
> > -     move_cost = (ptile->move_cost[dir] ? SINGLE_MOVE : 0);
> > +     /* NOT move_cost = MOVE_COST_ROAD (Syela) [why not? - Thue] 
> > +      * possibly because if an igter unit reuses warmap of a city 
> > +      * (see generate_warmap), it won't be THAT much different 
> > +      * from the correct warmap.  For consistency we should have 
> > +      * SINGLE_MOVE for disembarking igter unit too -- GB */
> 
> No. Please don't write novels in comments. Especially if they start
> with "possibly".

Why not? Really???
I think it's ok...

/Daniel

-- 
Now take a deep breath, smile and don't take life so seriously... :)