[Freeciv-Dev] Re: RFC: Fixing movement code

[Petr Baudis <pasky@xxxxxxxxxxx>]

> > > > c is zero everytime, no other assigment, so we can safely remove it
> > > > imho.
> > > 
> > > Maybe, maybe not. c is used in other ai functions.
> > Removed c and the assigment and it compiles fine for me. It really looks
> > this function was originally just copy of an older one, who knows.. However
> > 'c' looks like purely historical thing.
>
> c is used in numerous ai funcs. I just like to be absolutely sure of the ai
> code. Make one small change and it snowballs into an avalanche.
True. I'm dumb, I messed it up. When we remove c which is zero, we need to
remove too * SHIELD_COST after it. So the formula will look 'a bit' differently
:|.  Sorry for that, just discovered it now when feeding my patches to my
private AI CVS...

-- 

                                Petr "Pasky" Baudis

UN*X programmer, UN*X administrator, hobbies = IPv6, IRC
Real Users hate Real Programmers.
Public PGP key, geekcode and stuff: http://pasky.ji.cz/~pasky/