[Freeciv-Dev] Re: Tech cost patch

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Wed, Nov 28, 2001 at 02:51:51PM +0200, Juha Litola wrote:
> On Wed, Nov 28, 2001 at 02:49:46PM +0200, Juha Litola wrote:
> > On Wed, Nov 28, 2001 at 01:17:17PM +0200, Juha Litola wrote:
> > > Here is a patch implementing consistent tech costs.
> > And here is quick addition.
> And now it even has patch attached.

> diff -u -b -r1.166 packets.c
> --- common/packets.c  2001/10/18 16:45:32     1.166
> +++ common/packets.c  2001/11/28 12:48:29
> @@ -3754,6 +3754,7 @@
>    cptr=put_uint8(cptr, packet->nuke_contamination);
>    cptr=put_uint8(cptr, packet->granary_food_ini);
>    cptr=put_uint8(cptr, packet->granary_food_inc);
> +  cptr=put_uint8(cptr, packet->tech_cost_style);
>    if (has_capability("init_techs", pc->capability)) {
>      cptr = put_tech_list(cptr, packet->global_init_techs);
>    }
> @@ -3784,6 +3785,7 @@
>    iget_uint8(&iter, &packet->nuke_contamination);
>    iget_uint8(&iter, &packet->granary_food_ini);
>    iget_uint8(&iter, &packet->granary_food_inc);
> +  iget_uint8(&iter, &packet->tech_cost_style);
>    if (has_capability("init_techs", pc->capability)) {
>      iget_tech_list(&iter, packet->global_init_techs);
>    }

Please use capabilites.

> +/**************************************************************************
> + Function to determine cost for technology.
> + Equation is determined from game.rgame.tech_cost_style

> + 0 == Old style. Every tech increases cost by game.researchcost.

Old is a very relative word. Please exchange with "Civ and Civ2 style"
or just show the formula.

These are two problems I found during a first phase scanning of the
patch.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  "Heuer's Law: Any feature is a bug unless it can be turned off."