Complete.Org: Mailing Lists: Archives: freeciv-dev: November 2001:
[Freeciv-Dev] Re: new general-topologies patch

[Freeciv-Dev] Re: new general-topologies patch

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
Cc: freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: new general-topologies patch
From: vze2zq63@xxxxxxxxxxx
Date: Sun, 25 Nov 2001 09:00:20 -0500
Reply-to: jdorje@xxxxxxxxxxxx

Raimar Falke wrote:

On Sun, Nov 25, 2001 at 02:51:17AM -0500, vze2zq63@xxxxxxxxxxx wrote:

I've updated the general-topologies patch for current CVS, and placed it in incoming.

How do you relate this to (PR#1048)?

They are mostly conflicting.

Gaute's patch (almost) allows tori and cylinders by introducing special-case code into the server and (gtk) client. My patch allows any suitable topology (for the appropriate definition of suitable) by using a strict topology interface.

There would be some overlap in the map overview code (Gaute introduces and uses overview_x0/overview_y0; I mimic much of this change), but aside from that most of Gaute's patch is made obsolete by mine.

I'll continue to provide step-by-step patches to move toward the general-topologies goal - but I believe the CHECK_MAP_POS bugs are more important, and should be fixed before we go much further with this.


[Prev in Thread] Current Thread [Next in Thread]