[Freeciv-Dev] Re: map tiles in city dialog drawn in wrong order (PR#1044)

[Daniel Sjölie <deepone@xxxxxxxxxx>]

On 2001-11-01 14:46:39, Raimar Falke wrote:
> On Thu, Nov 01, 2001 at 12:24:43PM +0100, Daniel Sjölie wrote:
> > On 2001-11-01 11:40:28, Raimar Falke wrote:
> > > On Thu, Nov 01, 2001 at 02:22:17AM -0800, Andreas Beckmann wrote:
> > > > From: Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>
> > > > Date: Thursday, November 01, 2001 10:47 AM
> > > > 
> > > > >How can this be reproduced? Can you give a screenshot?
> > > > 
> > > > http://www.abeckmann.de/citydlg-error.png
> > > > (black has been replaced by white during screen capture - its not a 
> > > > freeciv
> > > > bug)
> > > 
> > > Indeed. Daniel?
> > > 
> > > This all shows that the nobody has tested the isometric view.
> > 
> > Pieter J. Kersten reported this bug last week... I did test isometric
> > view but I didn't notice this... Probably in part because this
> > presumably worked before september 30th and since nothing related to
> > this changed in the city dialog after that I probably didn't check
> > everything... And since the city gfx is smaller in the civ2 isometric
> > tileset I didn't notice anything there...
> > 
> > I'm not really into how those iterate functions are used all over so I
> > was kinda hoping that someone else would have something to say on the
> > matter... I will take a look though, if noone else comes forward...
> > 
> 
> > One question: Why not simply make city_map_iterate work like the
> > city_map_checked_bottom_up_iterate suggested by Andreas Beckmann?
> 
> Can't you just compare the old way to draw this and the current way?

I guess I could but it seems there are others who have a better
understanding of what's going on here...
Jason submitted a patch and even though I haven't tested it I think he
motivated it better than I ever could... :)

/Daniel

-- 
Now take a deep breath, smile and don't take life so seriously... :)