[Freeciv-Dev] Re: Dangerous danger2

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Thu, Oct 18, 2001 at 05:51:20PM -0700, Paul Zastoupil wrote:
> I was playing out a long game (yes, I was actually playing a game of
> Freeciv) and I got a bunch of server spam:
> Dangerous danger2 (%d) in %s.  Beware of overflow.
> 
> Its from "ai/advmilitary.c" line 377 of 1101
> 
> int danger2 = 0; /* linear for walls */
> <lots of stuff>
> if (!igwall) danger2 += v * m / dist;
> <lots of stuff>
> if (!igwall) danger2 += v * m / dist;
> <lots of stuff>
> if (danger2 < 0 || danger2 > 1<<24) /* I hope never to see this! */
>   freelog(LOG_ERROR, "Dangerous danger2 (%d) in %s.  Beware of overflow.",
>   danger2, pcity->name);
> 
> 
> I didn't really research it much more than that (come on, I know better
> than to go digging in the AI code).  Anyone still alive that understands
> this code?

As it says it is a check for overflow.

> Save game is available upon request.

If it is reproduceable from the savegame, post it here or mail it to
me.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "Premature optimization is the root of all evil."
    -- D. E. Knuth in "Structured Programming with go to Statements"